diff options
| author | Keith Packard <keithp@keithp.com> | 2013-03-24 15:00:20 -0700 |
|---|---|---|
| committer | Keith Packard <keithp@keithp.com> | 2013-03-31 12:24:24 -0700 |
| commit | 4f1f3e836393304434130d362771a39f6f8f859a (patch) | |
| tree | 5655f7ae7aa252a96aa585e3aee47b1b57a8fc9a /src/drivers/ao_packet.c | |
| parent | 7afcec1a1dce140dfa569469df4ef42ed407a742 (diff) | |
altos: Do not release interrupts from any pollchar function
getchar relies on interrupts being blocked across the pollchar calls
and into the sleep call or it may go to sleep with data pending.
This prefixes all pollchar functions with _ to indicate that they are
to be called with interrupts blocked and eliminates all interrupt
manipulation calls from within the pollchar functions.
Signed-off-by: Keith Packard <keithp@keithp.com>
Diffstat (limited to 'src/drivers/ao_packet.c')
| -rw-r--r-- | src/drivers/ao_packet.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/drivers/ao_packet.c b/src/drivers/ao_packet.c index 91319923..5a507478 100644 --- a/src/drivers/ao_packet.c +++ b/src/drivers/ao_packet.c @@ -169,12 +169,10 @@ ao_packet_putchar(char c) __reentrant tx_data[ao_packet_tx_used++] = c; } +/* May be called with interrupts blocked */ int -ao_packet_pollchar(void) +_ao_packet_pollchar(void) { - /* No need to block interrupts, all variables here - * are only manipulated in task context - */ if (!ao_packet_enable) return AO_READ_AGAIN; |