altoslib: Clean up AltosRecord clone methods

Make the AltosRecord version abstract and then implement suitable
versions in each subclass by creating copying constructors for each
class.

Signed-off-by: Keith Packard <keithp@keithp.com>

1 files changed, 2 insertions, 10 deletions

diff --git a/altoslib/AltosRecord.java b/altoslib/AltosRecord.java
index 09169515..2c4b6fa5 100644
--- a/altoslib/AltosRecord.java
+++ b/altoslib/AltosRecord.java
@@ -126,6 +126,8 @@ public abstract class AltosRecord implements Comparable <AltosRecord>, Cloneable
 		return tick - o.tick;
 	}
 
+	abstract public AltosRecord clone();
+
 	public void copy(AltosRecord old) {
 		seen = old.seen;
 		version = old.version;
@@ -144,16 +146,6 @@ public abstract class AltosRecord implements Comparable <AltosRecord>, Cloneable
 		kalman_height = old.kalman_height;
 	}
 
-	public AltosRecord clone() {
-		try {
-			AltosRecord n = (AltosRecord) super.clone();
-			n.copy(this);
-			return n;
-		} catch (CloneNotSupportedException e) {
-			return null;
-		}
-	}
-
 	public AltosRecord() {
 		seen = 0;
 		version = 0;