summaryrefslogtreecommitdiff
path: root/ao_serial.c
diff options
context:
space:
mode:
authorKeith Packard <keithp@keithp.com>2009-04-29 17:46:56 -0700
committerKeith Packard <keithp@keithp.com>2009-04-29 17:46:56 -0700
commitde7814c738488c2c16c6216c93fa78128895e5d5 (patch)
tree07a295d9f3786623e382a92bbab811ac19a78016 /ao_serial.c
parent4ae74fffb939d67424efa3e7f433637f1f920ebc (diff)
Use 'char' instead of 'uint8_t' for character data
String and character constants are of char type, so using uint8_t causes promotion to 16-bit types when comparing the two.
Diffstat (limited to 'ao_serial.c')
-rw-r--r--ao_serial.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/ao_serial.c b/ao_serial.c
index ae5e0764..20bb4f96 100644
--- a/ao_serial.c
+++ b/ao_serial.c
@@ -22,7 +22,7 @@
struct ao_fifo {
uint8_t insert;
uint8_t remove;
- uint8_t fifo[SERIAL_FIFO];
+ char fifo[SERIAL_FIFO];
};
volatile __xdata struct ao_fifo ao_usart1_rx_fifo;
@@ -71,10 +71,10 @@ ao_serial_tx1_isr(void) interrupt 14
ao_wakeup(&ao_usart1_tx_fifo);
}
-uint8_t
+char
ao_serial_getchar(void) __critical
{
- uint8_t c;
+ char c;
while (ao_fifo_empty(ao_usart1_rx_fifo))
ao_sleep(&ao_usart1_rx_fifo);
ao_fifo_remove(ao_usart1_rx_fifo, c);
@@ -82,7 +82,7 @@ ao_serial_getchar(void) __critical
}
void
-ao_serial_putchar(uint8_t c) __critical
+ao_serial_putchar(char c) __critical
{
while (ao_fifo_full(ao_usart1_tx_fifo))
ao_sleep(&ao_usart1_tx_fifo);