altoslib: Don't store computed telemetry fields

These values are only needed once, so there's no reason to save them.

Signed-off-by: Keith Packard <keithp@keithp.com>

1 files changed, 24 insertions, 45 deletions

diff --git a/altoslib/AltosTelemetryMegaData.java b/altoslib/AltosTelemetryMegaData.java
index 6ea5ec89..916f1e94 100644
--- a/altoslib/AltosTelemetryMegaData.java
+++ b/altoslib/AltosTelemetryMegaData.java
@@ -19,75 +19,54 @@
 package org.altusmetrum.altoslib_11;
 
 public class AltosTelemetryMegaData extends AltosTelemetryStandard {
-	int	state;
 
-	int	v_batt;
-	int	v_pyro;
-	int	sense[];
+	int	state() { return uint8(5); }
 
-	int	ground_pres;
-	int	ground_accel;
-	int	accel_plus_g;
-	int	accel_minus_g;
+	int	v_batt() { return int16(6); }
+	int	v_pyro() { return int16(8); }
+	int	sense(int i) { int v = uint8(10+i); return v << 4 | v >> 8; }
 
-	int	acceleration;
-	int	speed;
-	int	height_16;
+	int	ground_pres() { return int32(16); }
+	int	ground_accel() { return int16(20); }
+	int	accel_plus_g() { return int16(22); }
+	int	accel_minus_g() { return int16(24);}
 
-	public AltosTelemetryMegaData(int[] bytes) {
-		super(bytes);
-
-		state = uint8(5);
-
-		v_batt = int16(6);
-		v_pyro = int16(8);
-
-		sense = new int[6];
+	int	acceleration() { return int16(26); }
+	int	speed() { return int16(28); }
+	int	height_16() { return int16(30); }
 
-		for (int i = 0; i < 6; i++) {
-			sense[i] = uint8(10 + i) << 4;
-			sense[i] |= sense[i] >> 8;
-		}
-
-		ground_pres = int32(16);
-		ground_accel = int16(20);
-		accel_plus_g = int16(22);
-		accel_minus_g = int16(24);
-
-		acceleration = int16(26);
-		speed = int16(28);
-
-		height_16 = int16(30);
+	public AltosTelemetryMegaData(int[] bytes) throws AltosCRCException {
+		super(bytes);
 	}
 
 	public void update_state(AltosState state) {
 		super.update_state(state);
 
-		state.set_state(this.state);
+		state.set_state(state());
 
-		state.set_battery_voltage(AltosConvert.mega_battery_voltage(v_batt));
-		state.set_pyro_voltage(AltosConvert.mega_pyro_voltage(v_pyro));
+		state.set_battery_voltage(AltosConvert.mega_battery_voltage(v_batt()));
+		state.set_pyro_voltage(AltosConvert.mega_pyro_voltage(v_pyro()));
 
-		state.set_apogee_voltage(AltosConvert.mega_pyro_voltage(sense[4]));
-		state.set_main_voltage(AltosConvert.mega_pyro_voltage(sense[5]));
+		state.set_apogee_voltage(AltosConvert.mega_pyro_voltage(sense(4)));
+		state.set_main_voltage(AltosConvert.mega_pyro_voltage(sense(5)));
 
 		double voltages[] = new double[4];
 		for (int i = 0; i < 4; i++)
-			voltages[i] = AltosConvert.mega_pyro_voltage(sense[i]);
+			voltages[i] = AltosConvert.mega_pyro_voltage(sense(i));
 
 		state.set_ignitor_voltage(voltages);
 
-		state.set_ground_accel(ground_accel);
-		state.set_ground_pressure(ground_pres);
-		state.set_accel_g(accel_plus_g, accel_minus_g);
+		state.set_ground_accel(ground_accel());
+		state.set_ground_pressure(ground_pres());
+		state.set_accel_g(accel_plus_g(), accel_minus_g());
 
 		/* Fill in the high bits of height from recent GPS
 		 * data if available, otherwise guess using the
 		 * previous kalman height
 		 */
 
-		state.set_kalman(extend_height(state, height_16),
-				 speed/16.0, acceleration / 16.0);
+		state.set_kalman(extend_height(state, height_16()),
+				 speed()/16.0, acceleration() / 16.0);
 	}
 }